koolskateguy89 / gnome-shell-extension-spotify-controller

A GNOME Shell extension to control Spotify in the top bar
https://extensions.gnome.org/extension/4013/spotify-controller/
GNU General Public License v3.0
46 stars 3 forks source link

Icons showing even when spotify is closed #15

Closed tiklup11 closed 2 years ago

tiklup11 commented 2 years ago

Was working fine 2-3 weeks before. But now icons are there. It is turned off in settings.

koolskateguy89 commented 2 years ago
Erik0806 commented 2 years ago

I have the same issue, I'm on Gnome version 42 and the newest version of the extension that is on extensions.gnome.org (I think it is 11) As you start the laptop the control buttons are showing up (spotify is not starting automatically). As soon as you start spotify and then close it again it disappears and works correctly.

sergiotca commented 2 years ago

Gnome Shell 42.4 - X11 - Extension v11

I can confirm this behavior persists on latest shell and extension (buttons show up even when Spotify is closed): image They do go away once you open and close spotify, but I've noticed they tend to come back whenever I use any other media player.

I've also noticed the "play" button changes to the "pause" button when something (not spotify) is playing. But if you try and click on it, it does nothing. This is expected as I guess its function should be limited to spotify. In this example I was playing a podcast from my phone through bluetooth (not on the spotify app either btw):Captura desde 2022-08-15 15-53-18

koolskateguy89 commented 2 years ago

I've finally been able to reproduce this and know why this is happening:

I think I've fixed this by instead listening for when Spotify's name appears/disappears (i.e. when Spotify opens/closes), I'll push soon

Thank you @sergiotca for such a detailed comment, really helped me understand what was wrong

koolskateguy89 commented 2 years ago

Fixed version has been uploaded on EGO (v13)