koolskateguy89 / gnome-shell-extension-spotify-controller

A GNOME Shell extension to control Spotify in the top bar
https://extensions.gnome.org/extension/4013/spotify-controller/
GNU General Public License v3.0
45 stars 4 forks source link

Version 12 does not work on GNOME Shell 42.3 #17

Closed mortenfc closed 2 years ago

mortenfc commented 2 years ago

image

gnome-shell --version GNOME Shell 42.3.

I installed it using gnome-shell-extension-manager

when trying to install with Firefox' addon GNOME Shell integration , version 11.1, it gives error: image

Erik0806 commented 2 years ago

I just updated to the newest version and had the same error. Using PopOS by the way

Bloopps commented 2 years ago

Same here on Ubuntu 22.04

koolskateguy89 commented 2 years ago

Sorry I uploaded the wrong files unto EGO, I'll fix this soon

koolskateguy89 commented 2 years ago

I've fixed it now, v13

mortenfc commented 2 years ago

That did not fix. image

It fails to use the loaded / load the MediaPlayer class from mediaPlayer.js Copying its contents into extension.js fixes it

mortenfc commented 2 years ago

Well, it fixed it in version 12, but in version 13 I get another error after copying: image

koolskateguy89 commented 2 years ago

@mortenfc can you try changing mediaPlayer.js:36 to var MediaPlayer = class MediaPlayer { and let me know if it works

It works completely fine on my machine

mortenfc commented 2 years ago

@koolskateguy89 yes that fixes the not a constructor error, but I still need to remove the following 7 lines to fix the .toggle undefined error: Diff

koolskateguy89 commented 2 years ago

@mortenfc I see, that is very weird, I don't know why that causes the error.

Is it possible to just remove the first 5 lines and it still works?

KowerKoint commented 2 years ago

Same here on Pop!_OS 22.04.

Applying var MediaPlayer = class MediaPlayer { change and removing 5 lines in class ControlBar works.

davibpires commented 2 years ago

I still can't run the extensions since the update to version 12. I'm using Ubuntu 20.04. I can't see any error message. image