search

koongo-com / magento2-data-feed-manager

Koongo is an ultimate product data feed management tool that streamlines the process of product data export from Magento 2 store to any of 500+ price comparison websites, online marketplaces, and affiliate networks worldwide. Koongo helps you upload your product data to selling channels like Google Shopping, Shop.com, Facebook, Rakuten, Twenga, Bol.com, Beslist.nl, Bing Ads, and more.
6 stars 1 forks source link

Remove manual steps to install static assets (fonts), and automate th… #3

Closed hostep closed 1 year ago

hostep commented 1 year ago

…e install using magento/magento-composer-installer

This PR

This is a little-known feature in Magento, but you can see that Magento's magento/magento2-base module uses the same feature to copy files from it, to your Magento install. The difference is that magento/magento2-base is of type magento2-component, while this module is of type magento2-module. The type determines the location where files are copied to as described in the documentation. So I needed to prepend the path with ../../ so it would install the fonts in {root-magento-project}/lib and not {root-magento-project}/app/code/lib/

To test:

  1. Add the following to the repositories section of the composer.json file of a Magento installation: 
        {
        "type": "vcs",
        "url": "https://github.com/baldwin-agency/koongo-magento2-data-feed-manager"
    }
  2. Verify that lib/web/fonts/ does not has a directory Nostress_Koongo with the fonts from this module
  3. Execute: 
    composer require koongo-com/magento2-data-feed-manager:dev-automate-install-of-custom-fonts
  4. Verify that lib/web/fonts/ does have a directory Nostress_Koongo with the fonts from this module and that in the Magento backoffice the font is loaded correctly
  5. Execute: 
    composer remove koongo-com/magento2-data-feed-manager
  6. Verify that lib/web/fonts/ does not has a directory Nostress_Koongo with the fonts from this module
hostep commented 1 year ago

@pecinaon: if you have a little time, I would appreciate it if you could review this a bit, thanks! 🙂

hostep commented 1 year ago

Hey @pecinaon: what are your thoughts on this? Thanks!

hostep commented 1 year ago

Hey @pecinaon or @tomasfriedrich, have you guys already found some time to check this out? Thanks!

IlyaZha commented 1 year ago

Your contribution has been accepted, and we truly appreciate the time and effort you invested in it.

hostep commented 1 year ago

Super, thanks! 🙂

hostep commented 1 year ago

Hi @IlyaZha: when do you plan to release a new version with this fix included? Thanks!

pecinaon commented 1 year ago

Hello, we are still testing one new feature for batch processing of notifications, which should speed up the auctioning of the stores of users who also use the Koongo service.

I think we should release it by the end of the week.

Thanks for your help and have a nice day Andrew.