tests fail

[normanb]

Hi @chelm

tests are failing right now and you are also missing 11.geojson in the repo for the mapnik tests.

48 passing (3s) 8 failing

1) PostGIS Cache Model Tests when caching a github file should insert and get the sha: Uncaught AssertionError: expected undefined to exist at /Users/norman/projects/koop-server/test/models/cache.js:47:20 at /Users/norman/projects/koop-server/lib/Cache.js:60:11 at /Users/norman/projects/koop-server/lib/PostGIS.js:391:11 at null.callback (/Users/norman/projects/koop-server/lib/PostGIS.js:417:11) at Query.handleReadyForQuery (/Users/norman/projects/koop-server/node_modules/pg/lib/query.js:84:10) at null. (/Users/norman/projects/koop-server/node_modules/pg/lib/client.js:159:19) at EventEmitter.emit (events.js:117:20) at null. (/Users/norman/projects/koop-server/node_modules/pg/lib/connection.js:97:12) at Socket.EventEmitter.emit (events.js:95:17) at Socket. (_streamreadable.js:746:14) at Socket.EventEmitter.emit (events.js:92:17) at emitReadable (_stream_readable.js:408:10) at emitReadable (_stream_readable.js:404:5) at readableAddChunk (_stream_readable.js:165:9) at Socket.Readable.push (_stream_readable.js:127:10) at TCP.onread (net.js:526:21)

2) PostGIS Model Tests when caching a github file should select data from db: Uncaught AssertionError: expected 'Not Found' to not exist at /Users/norman/projects/koop-server/test/models/postgis-test.js:78:22 at /Users/norman/projects/koop-server/lib/PostGIS.js:220:19 at null.callback (/Users/norman/projects/koop-server/lib/PostGIS.js:417:11) at Query.handleError (/Users/norman/projects/koop-server/node_modules/pg/lib/query.js:101:10) at null. (/Users/norman/projects/koop-server/node_modules/pg/lib/client.js:167:26) at EventEmitter.emit (events.js:95:17) at null. (/Users/norman/projects/koop-server/node_modules/pg/lib/connection.js:97:12) at Socket.EventEmitter.emit (events.js:95:17) at Socket. (_streamreadable.js:746:14) at Socket.EventEmitter.emit (events.js:92:17) at emitReadable (_stream_readable.js:408:10) at emitReadable (_stream_readable.js:404:5) at readableAddChunk (_stream_readable.js:165:9) at Socket.Readable.push (_stream_readable.js:127:10) at TCP.onread (net.js:526:21)

3) PostGIS Model Tests when caching a github file should select data from db with filter: Uncaught AssertionError: expected 'Not Found' to not exist at /Users/norman/projects/koop-server/test/models/postgis-test.js:86:22 at /Users/norman/projects/koop-server/lib/PostGIS.js:220:19 at null.callback (/Users/norman/projects/koop-server/lib/PostGIS.js:417:11) at Query.handleError (/Users/norman/projects/koop-server/node_modules/pg/lib/query.js:101:10) at null. (/Users/norman/projects/koop-server/node_modules/pg/lib/client.js:167:26) at EventEmitter.emit (events.js:95:17) at null. (/Users/norman/projects/koop-server/node_modules/pg/lib/connection.js:97:12) at Socket.EventEmitter.emit (events.js:95:17) at Socket. (_streamreadable.js:746:14) at Socket.EventEmitter.emit (events.js:92:17) at emitReadable (_stream_readable.js:408:10) at emitReadable (_stream_readable.js:404:5) at readableAddChunk (_stream_readable.js:165:9) at Socket.Readable.push (_stream_readable.js:127:10) at TCP.onread (net.js:526:21)

4) PostGIS Model Tests when caching a github file should query data with AND filter:

  Uncaught AssertionError: expected 0 to be 7
  + expected - actual

  +7
  -0

  at Assertion.prop.(anonymous function) (/Users/norman/projects/koop-server/node_modules/should/lib/should.js:61:14)
  at /Users/norman/projects/koop-server/test/models/postgis-test.js:125:43
  at /Users/norman/projects/koop-server/lib/PostGIS.js:220:19
  at null.callback (/Users/norman/projects/koop-server/lib/PostGIS.js:417:11)
  at Query.handleError (/Users/norman/projects/koop-server/node_modules/pg/lib/query.js:101:10)
  at null.<anonymous> (/Users/norman/projects/koop-server/node_modules/pg/lib/client.js:167:26)
  at EventEmitter.emit (events.js:95:17)
  at null.<anonymous> (/Users/norman/projects/koop-server/node_modules/pg/lib/connection.js:97:12)
  at Socket.EventEmitter.emit (events.js:95:17)
  at Socket.<anonymous> (_stream_readable.js:746:14)
  at Socket.EventEmitter.emit (events.js:92:17)
  at emitReadable_ (_stream_readable.js:408:10)
  at emitReadable (_stream_readable.js:404:5)
  at readableAddChunk (_stream_readable.js:165:9)
  at Socket.Readable.push (_stream_readable.js:127:10)
  at TCP.onread (net.js:526:21)

5) PostGIS Model Tests when caching a github file should query data with many AND filters:

  Uncaught AssertionError: expected 0 to be 2
  + expected - actual

  +2
  -0

  at Assertion.prop.(anonymous function) (/Users/norman/projects/koop-server/node_modules/should/lib/should.js:61:14)
  at /Users/norman/projects/koop-server/test/models/postgis-test.js:154:43
  at /Users/norman/projects/koop-server/lib/PostGIS.js:220:19
  at null.callback (/Users/norman/projects/koop-server/lib/PostGIS.js:417:11)
  at Query.handleError (/Users/norman/projects/koop-server/node_modules/pg/lib/query.js:101:10)
  at null.<anonymous> (/Users/norman/projects/koop-server/node_modules/pg/lib/client.js:167:26)
  at EventEmitter.emit (events.js:95:17)
  at null.<anonymous> (/Users/norman/projects/koop-server/node_modules/pg/lib/connection.js:97:12)
  at Socket.EventEmitter.emit (events.js:95:17)
  at Socket.<anonymous> (_stream_readable.js:746:14)
  at Socket.EventEmitter.emit (events.js:92:17)
  at emitReadable_ (_stream_readable.js:408:10)
  at emitReadable (_stream_readable.js:404:5)
  at readableAddChunk (_stream_readable.js:165:9)
  at Socket.Readable.push (_stream_readable.js:127:10)
  at TCP.onread (net.js:526:21)

6) PostGIS Model Tests when caching a github file should query data with OR filters:

  Uncaught AssertionError: expected 0 to be 5
  + expected - actual

  +5
  -0

  at Assertion.prop.(anonymous function) (/Users/norman/projects/koop-server/node_modules/should/lib/should.js:61:14)
  at /Users/norman/projects/koop-server/test/models/postgis-test.js:183:43
  at /Users/norman/projects/koop-server/lib/PostGIS.js:220:19
  at null.callback (/Users/norman/projects/koop-server/lib/PostGIS.js:417:11)
  at Query.handleError (/Users/norman/projects/koop-server/node_modules/pg/lib/query.js:101:10)
  at null.<anonymous> (/Users/norman/projects/koop-server/node_modules/pg/lib/client.js:167:26)
  at EventEmitter.emit (events.js:95:17)
  at null.<anonymous> (/Users/norman/projects/koop-server/node_modules/pg/lib/connection.js:97:12)
  at Socket.EventEmitter.emit (events.js:95:17)
  at Socket.<anonymous> (_stream_readable.js:746:14)
  at Socket.EventEmitter.emit (events.js:92:17)
  at emitReadable_ (_stream_readable.js:408:10)
  at emitReadable (_stream_readable.js:404:5)
  at readableAddChunk (_stream_readable.js:165:9)
  at Socket.Readable.push (_stream_readable.js:127:10)
  at TCP.onread (net.js:526:21)

7) PostGIS Model Tests when caching a github file should get count: Uncaught TypeError: Cannot read property 'should' of null at /Users/norman/projects/koop-server/test/models/postgis-test.js:201:16 at /Users/norman/projects/koop-server/lib/PostGIS.js:39:9 at null.callback (/Users/norman/projects/koop-server/lib/PostGIS.js:417:11) at Query.handleError (/Users/norman/projects/koop-server/node_modules/pg/lib/query.js:101:10) at null. (/Users/norman/projects/koop-server/node_modules/pg/lib/client.js:167:26) at EventEmitter.emit (events.js:95:17) at null. (/Users/norman/projects/koop-server/node_modules/pg/lib/connection.js:97:12) at Socket.EventEmitter.emit (events.js:95:17) at Socket. (_streamreadable.js:746:14) at Socket.EventEmitter.emit (events.js:92:17) at emitReadable (_stream_readable.js:408:10) at emitReadable (_stream_readable.js:404:5) at readableAddChunk (_stream_readable.js:165:9) at Socket.Readable.push (_stream_readable.js:127:10) at TCP.onread (net.js:526:21)

8) The Tasker when exporting geojson should return a pointer to file: Uncaught TypeError: Cannot convert null to object at /Users/norman/projects/koop-server/lib/Tasker.js:25:12 at /Users/norman/projects/koop-server/lib/PostGIS.js:50:9 at null.callback (/Users/norman/projects/koop-server/lib/PostGIS.js:417:11) at Query.handleReadyForQuery (/Users/norman/projects/koop-server/node_modules/pg/lib/query.js:84:10) at null. (/Users/norman/projects/koop-server/node_modules/pg/lib/client.js:159:19) at EventEmitter.emit (events.js:117:20) at null. (/Users/norman/projects/koop-server/node_modules/pg/lib/connection.js:97:12) at Socket.EventEmitter.emit (events.js:95:17) at Socket. (_streamreadable.js:746:14) at Socket.EventEmitter.emit (events.js:92:17) at emitReadable (_stream_readable.js:408:10) at emitReadable (_stream_readable.js:404:5) at readableAddChunk (_stream_readable.js:165:9) at Socket.Readable.push (_stream_readable.js:127:10) at TCP.onread (net.js:526:21)

[chelm]

Ahh I best this cause I've hardcoded the name of my local db into the postgis test. Let me move that into a local config file that can be changed to match a local env.

[chelm]

actually maybe not, looking why they fail for you

[chelm]

@normanb Will you verify that you've pulled the latest code and re-run npm install

[normanb]

@chelm yes, done that, tests are still failing. The build is missing bunyan.

[chelm]

okay. I did a reshuffle of the package json deps for koop and koop-server so its from that. Pull again and try? just pushed. And npm install.

[normanb]

same errors, I can dig into the code and look.

On Mon, Jun 23, 2014 at 10:48 AM, Christopher Helm <notifications@github.com

wrote:

okay. I did a reshuffle of the package json deps for koop and koop-server so its from that. Pull again and try? just pushed. And npm install.

— Reply to this email directly or view it on GitHub https://github.com/Esri/koop-server/issues/4#issuecomment-46870541.

[chelm]

@normanb If you look at the very last test: should get count and log the error I bet that will tell us. My guess is that the insert in the before method is failing. Actually put a log in the insert on line 26 and wrap the call to done in a function that takes err, and res.

[normanb]

@chelm I have got this down to one failing test now. I needed to install postgis from source and then my Mac was setup, sorry about that. Failing test is now

1 failing

1) The Tasker when exporting geojson should return a pointer to file: Uncaught TypeError: Cannot convert null to object at /Users/norman/projects/koop-server/lib/Tasker.js:25:12 at /Users/norman/projects/koop-server/lib/PostGIS.js:50:9 at null.callback (/Users/norman/projects/koop-server/lib/PostGIS.js:417:11) at Query.handleReadyForQuery (/Users/norman/projects/koop-server/node_modules/pg/lib/query.js:84:10) at null. (/Users/norman/projects/koop-server/node_modules/pg/lib/client.js:159:19) at EventEmitter.emit (events.js:117:20) at null. (/Users/norman/projects/koop-server/node_modules/pg/lib/connection.js:97:12) at Socket.EventEmitter.emit (events.js:95:17) at Socket. (_streamreadable.js:746:14) at Socket.EventEmitter.emit (events.js:92:17) at emitReadable (_stream_readable.js:408:10) at emitReadable (_stream_readable.js:404:5) at readableAddChunk (_stream_readable.js:165:9) at Socket.Readable.push (_stream_readable.js:127:10) at TCP.onread (net.js:526:21)

I will dig into this.

[chelm]

@normanb Awesome work on the spatialite backend. You are amazing. Is this good to close?

[normanb]

@chelm great, thanks! We are good to close. I will issue another PR for adding a spatial index to geojson.

On Fri, Jul 18, 2014 at 9:34 AM, Christopher Helm notifications@github.com wrote:

@normanb https://github.com/normanb Awesome work on the spatialite backend. You are amazing. Is this good to close?

— Reply to this email directly or view it on GitHub https://github.com/Esri/koop-server/issues/4#issuecomment-49444703.