search

koopjs / FeatureServer

An open source Geoservices Implementation (deprecated)
https://geoservices.github.io
Other
101 stars 32 forks source link

Fix payloads when idField is set #139

Closed rgwozdz closed 5 years ago

rgwozdz commented 5 years ago

This PR removes a workaround (implemented 5 or 6 months ago) that helped get koop working on ArcGIS clients. The workaround added an OBJECTID field to payloads even if a provider had set idField in the provider metadata. The result was two properties with the same value. This is not ideal, for reasons noted in koopjs/FeatureServer#127.

The original bug was in Winnow, and there is a PR in place that fixes the bug. This PR removes the workarounds required in FeatureServer. It also refactors a great deal of the unit tests that leverage Joi schema tests.

rgwozdz commented 5 years ago

Bumped winnow version and removed [WIP].