search

koopjs / FeatureServer

An open source Geoservices Implementation (deprecated)
https://geoservices.github.io
Other
104 stars 32 forks source link

drop type from features array in query response #46

Closed jgravois closed 7 years ago

jgravois commented 7 years ago

'type' is a GeoJSON thing

http://resources.arcgis.com/en/help/arcgis-rest-api/index.html#/Feature_object/02r3000000n8000000

jgravois commented 7 years ago

more info: https://github.com/koopjs/koop-provider-google-sheets/pull/9#issuecomment-329265275

dmfenton commented 7 years ago

Still the wrong place, this needs to happen inside Winnow otherwise we're adding an additional loop over all features

dmfenton commented 7 years ago

Check out this part of Winnow: https://github.com/koopjs/winnow/blob/master/src/executeQuery.js#L60-L73

dmfenton commented 7 years ago

Actually it needs to happen in this code block https://github.com/koopjs/winnow/blob/master/src/select/fields.js#L8-L10

if options.toEsri is set, we should not include type in the select clause