search

koopjs / FeatureServer

An open source Geoservices Implementation (deprecated)
https://geoservices.github.io
Other
104 stars 32 forks source link

F/support pagination applied #56

Closed mbrownkinetica closed 6 years ago

mbrownkinetica commented 6 years ago

Adds a parameter to the filtersApplied object for offset, that when set to true, will reset the resultOffset back to 0 to avoid slicing problems during the finishQuery function later. This fix is particularly important for those users who have already applied pagination during their database query in the getData method of Koop.

mbrownkinetica commented 6 years ago

My pleasure @dmfenton, I've added a simple test in there as well. Does that cover it?

dmfenton commented 6 years ago

Yes this looks great. Last step is to add this new filtersApplied into the readme docs and I'll merge this PR.

mbrownkinetica commented 6 years ago

Good catch! I've added that param to the object definition in the readme.

dmfenton commented 6 years ago

published in 2.5.0