DNM: Support use of a provider's metadata idField as full-fledge OBJECTID - Githubissues

koopjs / FeatureServer

An open source Geoservices Implementation (deprecated)

https://geoservices.github.io

Other

104 stars 32 forks source link

DNM: Support use of a provider's metadata idField as full-fledge OBJECTID #94

Closed rgwozdz closed 6 years ago

rgwozdz commented 6 years ago

DO NOT MERGE. Changes and tests here currently dependent on anticipated PR merge in winnow.

Assumptions:

For an OBJECTID to fully support ArcGIS clients, it must have name and alias equal to OBJECTID
If a model's idField is set to a given attribute, and the format option is not geojson, we can use the value of the idField attribute as the OBJECTID value, and then delete the original idField attribute so that the information is duplicated in the attributes object

This PR:

Adds warning if a request is aimed at a provider that has not assigned an idField to its metadata.
Adds warning if a request returns OBJECTIDs that are not integers or are out of range
Alters the creation of the fields objects to account for the use of a model's attribute as the OBJECTID (the idField), and when doing so, conforms to the assumptions listed above

rgwozdz commented 6 years ago

Superseded by subsequent PR.