search

koopjs / koop-auth-direct-file

Koop authentication plugin using file-based identity-store
Other
8 stars 4 forks source link

This auth provider does not seem to work with Koop 4 #11

Closed bveldkamp closed 1 year ago

bveldkamp commented 2 years ago

koop-auth-direct-file references Koop ^3.7.2, so when using 4.x, this dependency won't resolve.

I suppose this can be fixed by simply altering the version in package.json, but I don't know if the workings of an auth module have changed between 3.x and 4.x?

rgwozdz commented 2 years ago

Thanks for surfacing this. I actually think this is a misuse of peer-dependencies. It should still work with latest Koop. We can remove both peer dependencies from the package.json. Would you care to PR?

bveldkamp commented 2 years ago

I'm away for a couple of weeks, so if you don't mind that, sure.