search

koopjs / koop-opendata

ArcGIS Open Data provider for Koop (experimental).
Apache License 2.0
4 stars 2 forks source link

1.0.0 release does not match npm release #8

Closed ungoldman closed 9 years ago

ungoldman commented 9 years ago

https://github.com/koopjs/koop-opendata/releases/tag/1.0.0 does not match 1.0.0 on https://www.npmjs.com/package/koop-opendata.

We need to either unpublish what's on NPM and redo the publish step to match what's on github, or delete the release on github and bump the version.

@dmfenton

ungoldman commented 9 years ago

It would also be best to have a change log in there before making the release official.

dmfenton commented 9 years ago

Cool, thanks for keeping me honest. I'll clean it up today.

ungoldman commented 9 years ago

@dmfenton is it alright if I fix the tags & releases for this repo? I want to make them consistent with the rest of the koopjs repos.

dmfenton commented 9 years ago

Sure

On Tue, Jun 30, 2015 at 4:15 PM -0700, "Nate Goldman" notifications@github.com<mailto:notifications@github.com> wrote:

@dmfentonhttps://github.com/dmfenton is it alright if I fix the tags & releases for this repo? I want to make them consistent with the rest of the koopjs repos.

— Reply to this email directly or view it on GitHubhttps://github.com/koopjs/koop-opendata/issues/8#issuecomment-117370308.

dmfenton commented 9 years ago

I thought I fixed the offending release on NPM by doing unpublish.

ungoldman commented 9 years ago

nope, it's still there. will fix github releases for now.

ungoldman commented 9 years ago

actually it's not, sorry, was looking at time instead of versions from npm info koop-opendata

  versions: [ '1.0.1', '1.1.0', '1.1.1', '1.1.3', '1.1.4' ],
  maintainers: 'dmfenton <dfenton@esri.com>',
  time:
   { modified: '2015-07-01T20:57:44.900Z',
     created: '2015-06-15T16:51:36.668Z',
     '1.0.0': '2015-06-15T16:51:36.668Z',
     '1.0.1': '2015-06-25T12:36:12.389Z',
     '1.1.0': '2015-06-30T20:13:53.878Z',
     '1.1.1': '2015-07-01T14:58:33.995Z',
     '1.1.2': '2015-07-01T18:43:15.836Z',
     '1.1.3': '2015-07-01T20:31:43.941Z',
     '1.1.4': '2015-07-01T20:57:44.900Z' }

will remove 1.0.0 and 1.1.2 from releases. should be fine now.

ungoldman commented 9 years ago

In the future, keeping version commits separate makes tracking releases and going through history a whole lot easier for users and maintainers. For example https://github.com/ngoldman/module-init/commit/5c0662afae2b408093c5b42a1d1322fed6a059ad is easy to spot and understand when scanning through git history (https://github.com/ngoldman/module-init/commits/master).

dmfenton commented 9 years ago

Cool, will do so in the future. Thanks for the help.