search

koopjs / koop-pgcache

PostGIS cache for Koop.
Other
4 stars 4 forks source link

upgraded to JSONB FTW #36

Closed dmfenton closed 9 years ago

dmfenton commented 9 years ago

Advisory: this is a breaking change for the order_by function

This PR upgrades koopinfo->info and feature columns to use JSONB. The benefits are increased performance in selecting data (although writes will take longer) and more importantly we can correctly sort by numeric types now.

It also includes a script for upgrading all json columns to jsonb. Expect this script to run for a long time at 100% cpu. 30 minutes on my machine

cc @koopjs/dev

dmfenton commented 9 years ago

Note we need to have travis using postgres 9.4

ungoldman commented 9 years ago

Breaking change means major version bump. Is koop-pgcache ready for 2.0?

dmfenton commented 9 years ago

I think we should also fix the select statement so it only makes one request. I'm not sure if that's going to mean breaking changes though. Nothing else is on the radar at this time.

ungoldman commented 9 years ago

@dmfenton That sounds like a good plan. :+1: