search

koopjs / koop-pgcache

PostGIS cache for Koop.
Other
4 stars 4 forks source link

clean up _insertFeature #39

Closed kneemer closed 8 years ago

kneemer commented 8 years ago

Remove unused code. Resolves #38

ungoldman commented 8 years ago

@kneemer mind adding a line to the change log? otherwise looks great :grin:

kneemer commented 8 years ago

@ngoldman is this what you had in mind?

ungoldman commented 8 years ago

Also a note about removing CRS as that's a little more major

kneemer commented 8 years ago

Well, it wasn't actually using it.

kneemer commented 8 years ago

It was getting set after stringifying and geohashing the feature and not used in the insert query at all.

ungoldman commented 8 years ago

@kneemer was the crs getting attached to the geojson object returned to the client?

ungoldman commented 8 years ago

@kneemer sorry merged another pull request, can you rebase? other than that it looks good time, thanks!

kneemer commented 8 years ago

@ngoldman rebase complete

ungoldman commented 8 years ago

:+1: