search

koopjs / koop-pgcache

PostGIS cache for Koop.
Other
4 stars 4 forks source link

Use geometry type in the DB #43

Closed dmfenton closed 8 years ago

dmfenton commented 8 years ago

This PR merges in @peacenlove's work. It uses geometry types in the database instead of casting from geojson

dmfenton commented 8 years ago

cc @koopjs/dev

ungoldman commented 8 years ago

Ideally you can cherry pick the commit or rebase off the branch and modify it so that they still receive credit for the contribution.

dmfenton commented 8 years ago

Yeah that's what I did (I checked out his branch anyways), but I guess it overwrote his commits when I merged locally. Weird.

PeaceNlove commented 8 years ago

Thanks :-)

dmfenton commented 8 years ago

I get what you're saying now. Would have helped it we had a test around this. Granted I did just snag your commits :stuck_out_tongue:

We're going to have to migrate our data anyways due to jsonb. Still trying to figure out how that's going to work in practice.

PeaceNlove commented 8 years ago

:) Jsonb looks interesting. Never heard of it until you mentioned it. I learned something as well tonight :)