koopjs / koop-provider-agol

ArcGIS Online provider for Koop (public services only).
Other
12 stars 10 forks source link

Errors should be normalized and in the requested MIME-Type format #32

Closed ajturner closed 8 years ago

ajturner commented 9 years ago

Requesting

http://firstmap.delaware.opendata.arcgis.com/datasets/5d1d1faf58344909b36b14b6be2f0748_0.csv?url_only=true

starts with {"status":"processing","processing_time":13840.153,"count":0}, and then after some error responds with plain text Could not create export, missing data

/cc @dmfenton

dmfenton commented 9 years ago

We should take this as an opportunity to refactor status messages throughout all of Koop. Not just any one provider.

jwieringa commented 9 years ago

All error messages being returned in JSON is not a bug, it is done on purpose. We can discuss why and the problems we solved by doing this.

ajturner commented 9 years ago

@jwieringa you mean that "All error messages not being returned in JSON is not a bug"?

dmfenton commented 8 years ago

This is done. If we find cases where I missed something we can log new bugs.