search

koopjs / koop-provider-agol

ArcGIS Online provider for Koop (public services only).
Other
12 stars 10 forks source link

bump to standard 5 #64

Closed ungoldman closed 9 years ago

ungoldman commented 9 years ago

just some reformatting to pass standard 5+ and a couple readability improvements

ungoldman commented 9 years ago

noticed errors aren't standard here, as in

task.callback({ code: 400, error: 'Trouble parsing the CSV data' }, null)

at https://github.com/koopjs/koop-agol/pull/64/files#diff-2c02d67f20cb34e38b68a7584305888fR419

is it worth me doing a pass on that @dmfenton?

I'd do the same as in featureservice -- new Error(msg) + any extra properties like code tacked on.

dmfenton commented 9 years ago

Yep that would be very helpful. Pgcache really needs it as well. I was planning to do that to make some things easier on #62

ungoldman commented 9 years ago

@dmfenton guessing you mean #62? #63 is about bumping esri-leaflet version.

ungoldman commented 9 years ago

I will do that in another PR.

dmfenton commented 9 years ago

yeah #62

ungoldman commented 9 years ago

:grin: