Modular output via plugins

koopjs / koop-provider-ckan

CKAN provider for Koop (experimental).

Other

4 stars 5 forks source link

Modular output via plugins #9

Open timwis opened 9 years ago

timwis commented 9 years ago

Stemming from esri/koop#195, this pull request proposes the following path for queries

provider -> router -> controller.findResource
- interface.parse
- parse SELECT and WHERE params into some common form (SQL string, ORM, or JS object)
- model.getResource
- cache.get
  - db.select
  - same logic as before but using the common form described above
  - also parse select/outfields here
- interface.formatOutput
- convert GeoJSON to expected output of interface

NOTE this pull request depends on pull koopjs/koop#226

ungoldman commented 9 years ago

Your implementation makes sense to me, but tests are not passing. I'm going to pull this down and refactor a bit.

ungoldman commented 9 years ago

Wow, realizing this module is really out of date. I'll refactor and incorporate your changes. Thanks @timwis for bringing attention to this.

timwis commented 9 years ago

Interesting... which module is the most up-to-date? Curious how the new ones work / direction it's going

ungoldman commented 9 years ago

@timwis: @dmfenton is actively working on refactoring koop-agol, and I believe koop-socrata is the most robust and up to date as of right now. We're actively working on improving patterns and maturing the project. @chelm has basically been solo on all of these modules for a long time (a monumental task), and we've only recently devoted more resources to be able to come in to help out and make the project more usable for outside use cases (for folks like you). We're running koop & koop-agol in production for datasets hosted through ArcGIS Open Data.

jgravois commented 8 years ago

@ngoldman thank you so much for refactoring and including tests in #10. it doesn't look like you cherry picked any of @timwis' commits, but i'm guessing you incorporated the helpful work yourself.

is this correct? does that mean this PR is safe to close?

ungoldman commented 8 years ago

@jgravois nothing from here is incorporated as far as I know @jgravois. that PR was from a long time ago :(

jgravois commented 8 years ago

nothing from here is incorporated as far as I know

no worries. i'll try and take a look soon.