property "aid" needs clarification

koopjs / koop-provider-composite

Combine multiple geoservices into a common, normalized geoservice

Other

4 stars 3 forks source link

property "aid" needs clarification #13

Open apfister opened 6 years ago

apfister commented 6 years ago

it isn't clear that aid needs to be explicitly included in your JSON schema for your indicator. can we remove this completely and just have model.js handle it so the user doesn't need to worry about it?

https://github.com/koopjs/koop-provider-composite/blob/master/files/put_initiative.sh#L83-L85 && https://github.com/koopjs/koop-provider-composite/blob/master/model.js#L316

dmfenton commented 6 years ago

yes I agree with you. users shouldn't have to know anything about this implementation detail