support specifying id field

koopjs / koop-provider-csv

Koop provider for CSV

MIT License

5 stars 3 forks source link

support specifying id field #2

Closed haoliangyu closed 5 years ago

hhkaos commented 5 years ago

Hi @haoliangyu, I have been playing around with your code today and did some changes to make it work with a CSV file I have produced using csv-writer. I have also improved the code to avoid the warning about the idField.

I can do a pull request of my code if you want.

By the way, thanks for sharing :smile:

haoliangyu commented 5 years ago

@hhkaos This is an awesome job. I especially like the stream approach to handle CSV file :+1: Please do the PR!

Can you add a reference/link to the idField documentation? I am not clear about the logic.

hhkaos commented 5 years ago

Sure!, I had this same issue some time ago with another provider.

You can find the documentation here:

I have done another improvement based on an issue I was having with a 13MB CSV full of tweets ^_^