Proposed Improvements

[drewdaemon]

First round of proposed improvements

• Restructure provider to follow standards (https://github.com/koopjs/koop-provider-example#koop-provider-file-structure)
  • provider/models/esmodel.js -> src/model.js and refactor to be an ES6 class
  • move initialization logic here and here to functions called from the Model class constructor and nix app.js
  • provider/controllers/index.js -> src/index.js
  • provider/utils.js -> src/utils.js and refactor utils to be pure, classless JS functions exported from a utils module using a "bucket" file.
  • Drop Express and Koop instantiation logic
• Drop these pointless things: https://github.com/koopjs/koop-provider-elasticsearch/blob/master/app.js#L118-L128
• Clean this up: https://github.com/koopjs/koop-provider-elasticsearch/blob/master/provider/models/esmodel.js#L28-L63
• Add tests

Outstanding Questions

• What do we do to adapt appConfig.json and this bespoke cert-loading system into the standardized spec?

[drewdaemon]

@rgwozdz

[rgwozdz]

@drewctate - I would suggest moving away from an appConfig.json in favor of the npm config module; many other Koop providers use it, so we'll gain some consistency there.

[dhatcher]

@drewctate We're looking into a complete overhaul/update of the provider. We'll look at these ideas with that effort.

[rgwozdz]

@dhatcher - do you have a timeline for your overhaul? @drewctate has an interest in starting this now (may have started it already). If he has started it, would you be able to assist or maybe do PR reviews?

[dhatcher]

This work is being done under the koop-4.x-update branch.