search

koopjs / koop-provider-marklogic

A Koop Provider that can be used to exposed data in MarkLogic via Esri feature services
https://koopjs.github.io/koop-provider-marklogic/
Other
6 stars 11 forks source link

Replacing flora parser with Optic API in-built parser Issue#20 #49

Closed jkerr5 closed 5 years ago

jkerr5 commented 6 years ago

@jmamanpara creating this for you

jkerr5 commented 6 years ago

@jmamanpara A couple of issues on this: 1) The WhereTest.testGreaterThanTimestamp test is failing for me with the wrong count. I believe it has something to do with timestamps. Esri assumes date fields are in UTC time so I had some code in the old date handling logic that was setting all the incoming query dates and times to UTC. Using the new op.sqlCondition call is likely parsing the dates and times into the local timezone so we get different results when we run the test. - The fix for this is more custom handling of date strings. This makes me question if it really is the best idea to remove the use of the flora parser yet. We may be able to control the timezone in the implicit context though and that could resolve this too. 2) If we are removing the use of the flora parser, we should remove the referenced libraries too.

jkerr5 commented 5 years ago

We never merged this due to issues with date handling in the built in where clause parsing. There have been bugs fixed on the MarkLogic side since this was tested though so we may want to retest.

jkerr5 commented 5 years ago

This is a change to a key internal component that is low priority to test right now so we are just closing this PR for now. We will revisit if/when it comes up again.