search

koopjs / koop-provider-yelp

Yelp provider for Koop.
Other
3 stars 3 forks source link

Update usage of js-combinatorics #5

Closed rgwozdz closed 3 years ago

rgwozdz commented 6 years ago

route.js implements js-combinatorics as:

var Combinatorics = require('js-combinatorics').Combinatorics;

But this produces:

var combinations = Combinatorics.permutationCombination(parameters).toArray();
                                 ^
TypeError: Cannot read property 'permutationCombination' of undefined

Solved by changing require to

var Combinatorics = require('js-combinatorics');
gavinr commented 3 years ago

I don't think we're using this in here anymore - @rgwozdz can this issue be closed?

rgwozdz commented 3 years ago

Ha, sure, I have no memory of writing this.