search

koopjs / koop-provider-yelp

Yelp provider for Koop.
Other
3 stars 3 forks source link

yelp api v3 (yelp-fusion) #7

Closed gavinr closed 3 years ago

gavinr commented 3 years ago

resolves #6 resolves #4

haoliangyu commented 3 years ago

Wow, great PR! I am adding this to my review list.

rgwozdz commented 3 years ago

@gavinr - also if you are going to have the Yelp API do geometry and where you should add filtersApplied object to the root of your GeoJSON object so that Koop does not try to do it a second time. Here's the spec:

filtersApplied: {
    geometry: Boolean, // true if a geometric filter has already been applied to the data
    where: Boolean, // true if a sql-like where filter has already been applied to the data
    offset: Boolean // true if the result offset has already been applied to the data,
    limit: Boolean // true if the result count has already been limited,
  }
gavinr commented 3 years ago

@haoliangyu that is in place, thanks. After merge I will add issues to follow-up on the additional issues left above

rgwozdz commented 3 years ago

I'll release and publish shortly.