koopjs / koop

Transform, query, and download geospatial data on the web.
http://koopjs.github.io
Other
651 stars 125 forks source link

fix: remove single vertex rings and paths from quantized geometry #1004

Closed rgwozdz closed 1 month ago

rgwozdz commented 1 month ago

Quanitzation applied to PBF encoding needs to strip out single vertex rings/paths that can occur when quantization scaling occurs at wide extents. Leaving these single vertex rings/paths results in fault geometry. See below:

Screenshot 2024-05-13 at 11 27 04 AM

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 7ca838eccf4975be2bf975f37bf71ca8a2bdcbf3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | -------------------------- | ----- | | @koopjs/featureserver | Patch | | @koopjs/output-geoservices | Patch | | @koopjs/koop-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

Coverage Report (change vs master)

File Path Statements Branches Functions Lines
packages/featureserver/src/response-handlers/helpers/send-pbf/transform-to-pbf-geometry.js 100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green