koopjs / koop

Transform, query, and download geospatial data on the web.
http://koopjs.github.io
Other
654 stars 125 forks source link

Handle "where" param with + #933

Closed rgwozdz closed 4 months ago

rgwozdz commented 4 months ago

GeoServices API specification allows a where that uses + as a placeholder for whitespace. So something like this is valid:

where=Foo+IS+NOT+NULL

The current release of Koop rejects where params that are constructed with the + delimiter. This PR patches this limitation.

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: bf48f3672d7cafd9a0fa7a0cc74d61ed5cfd30d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | -------------------------- | ----- | | @koopjs/featureserver | Patch | | @koopjs/output-geoservices | Patch | | @koopjs/koop-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 4 months ago

Coverage Report (change vs master)

File Path Statements Branches Functions Lines
packages/featureserver/src/query/filter-and-transform.js 100 green vs 100 green 100 green vs 94.11 yellowGreen 100 green vs 100 green 100 green vs 100 green
packages/featureserver/src/query/index.js 100 green vs 100 green 94.28 yellowGreen vs 94.28 yellowGreen 100 green vs 100 green 100 green vs 100 green