fix: allow proper encoding of string OIDs in PBF format

koopjs / koop

Transform, query, and download geospatial data on the web.

http://koopjs.github.io

Other

667 stars 128 forks source link

fix: allow proper encoding of string OIDs in PBF format #946

Closed rgwozdz closed 7 months ago

rgwozdz commented 7 months ago

Koop allows use of strings as OBJECTIDs. While ArcGIS OBJECTIDs are supposed to be integers, many ArcGIS clients seem to work without issue if OBJECTIDs or FIDs are strings. Big exception is ArcGIS Pro - it fails with datasets that don't use integers.

The currently released PBF encoder in Koop doesn't properly encode string OBJECTIDs. This results in 0 values for the OBJECTIDs when decoded by clients. The PR fixes.

changeset-bot[bot] commented 7 months ago

🦋 Changeset detected

Latest commit: 2f951595d3c9567798796a819df35b8e79e64007

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

| Name | Type | | -------------------------- | ----- | | @koopjs/featureserver | Patch | | @koopjs/output-geoservices | Patch | | @koopjs/koop-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 7 months ago

Coverage Report (change vs master)

File Path	Statements	Branches	Functions	Lines
packages/featureserver/src/response-handlers/helpers/send-pbf/transform-to-pbf-attributes.js	100 vs 100	100 vs 100	100 vs 100	100 vs 100