koopjs / koop

Transform, query, and download geospatial data on the web.
http://koopjs.github.io
Other
651 stars 125 forks source link

Refactor FeatureServer/Output-GeoServices Integration #999

Closed rgwozdz closed 2 months ago

rgwozdz commented 2 months ago

This PR accumulates changes from a series of PRs merged individual to next. The object of this effort is to remove the complex routing and validation logic in the route module of the FeatureServer package and instead (1) let Express handling route matching, and (2) let individual handlers do parameter validation. To do this, the handlers for each route had to be refactored so that they all accepted the Express request and response object, as well as the GeoJSON from the provider (if needed).

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: af716150d79ac748824b5382fef78ade5d070a54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | -------------------------- | ----- | | @koopjs/featureserver | Major | | @koopjs/output-geoservices | Patch | | @koopjs/koop-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 months ago

Coverage Report (change vs master)

File Path Statements Branches Functions Lines
packages/featureserver/src/index.js 100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
packages/featureserver/src/layer-info-handler.js 100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
packages/featureserver/src/layers-info-handler.js 100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
packages/featureserver/src/rest-info-route-handler.js 100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
packages/featureserver/src/server-info-route-handler.js 100.0 green
vs
98.1 yellowGreen
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
98.1 yellowGreen
packages/featureserver/src/generate-renderer/build-renderer.js 100.0 green
vs
(NA)
90.5 yellowGreen
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
packages/featureserver/src/generate-renderer/index.js 100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
packages/featureserver/src/helpers/combine-body-query-params.js 100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
packages/featureserver/src/helpers/index.js 100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
packages/featureserver/src/helpers/normalize-input-data.js 100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
packages/featureserver/src/helpers/normalize-request-params.js 100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
packages/featureserver/src/helpers/shared-query-request-param-schema.js 100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
packages/featureserver/src/helpers/validate-info-route-params.js 100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
packages/featureserver/src/query/index.js 100.0 green
vs
100.0 green
100.0 green
vs
94.3 yellowGreen
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
packages/featureserver/src/query/query-json.js 100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
packages/featureserver/src/query/validate-query-request-parameters.js 100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
packages/featureserver/src/query-related-records/index.js 100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
packages/featureserver/src/query-related-records/query-related-records.js 86.7 yellow
vs
(NA)
83.3 yellow
vs
(NA)
100.0 green
vs
(NA)
86.2 yellow
vs
(NA)
packages/featureserver/src/query-related-records/validate-query-related-request-parameters.js 100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
100.0 green
vs
(NA)
packages/output-geoservices/src/index.js 100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green
100.0 green
vs
100.0 green