search

koopjs / koopjs.github.io

Home of the Koop Geospatial Server.
https://koopjs.github.io
Apache License 2.0
14 stars 28 forks source link

adds proposed spec for cache #4

Closed dmfenton closed 9 years ago

dmfenton commented 9 years ago

@chelm @ngoldman @jgravois I could use some review here.

dmfenton commented 9 years ago

I think for the next version of Koop, we should standardize the way tables are selected from the cache. Right now it's a mix of key and table + layer.

chelm commented 9 years ago

What I really like about this is it will force us to closely look at what we pass into various methods. It a great opp to address consistency between the cache methods, koop's Cache wrapper and each provider.

@dmfenton is this doc missing the services* methods?

dmfenton commented 9 years ago

That was definitely my goal here. Let's get existing doc'd then we can propose a better version for the refactor.

I don't see references to any services methods in koop-pgcache or lib/cache. What are you referring to?

chelm commented 9 years ago

@dmfenton - maybe it just not meant to be complete? but in pgcache there is https://github.com/Esri/koop-pgcache/blob/master/index.js#L542-L601

I think the problem is that the providers that use those methods must not be going through lib/Cache which needs to change.

dmfenton commented 9 years ago

Oh, I see. Yeah, I'm not sure that is happening in lib/Cache.

ungoldman commented 9 years ago

@dmfenton merging for now as it's a good working draft, we can continue the discussion and revise as necessary