search

koopjs / winnow

Deprecated
Apache License 2.0
90 stars 18 forks source link

Feature / Use AST to translate WHERE clause #54

Closed haoliangyu closed 6 years ago

haoliangyu commented 6 years ago

This PR will parse the input WHERE clause into AST, instead of doing regex matching, and traverse the tree to generate translated clause. Not many comments are added since the implementation is very straightforwards. No regex hack :-)

From what I can tell from the test running, the speed is the same.

This PR has covered the problem at #53.

dmfenton commented 6 years ago

nice work! I'm sure it's going to work, but will you add in a test case for the specific issue that kicked this off?

haoliangyu commented 6 years ago

@dmfenton Do you mean these two tests?

dmfenton commented 6 years ago

I mean a test specifically for the bug in: https://esriarlington.tpondemand.com/entity/81713