search

koopjs / winnow

Deprecated
Apache License 2.0
90 stars 18 forks source link

Ordering is broken #84

Closed efbenson closed 6 years ago

efbenson commented 6 years ago

https://github.com/koopjs/winnow/blob/5ba3ada345f066de251fb470f9e7c1031bde2405/src/executeQuery.js#L64

Because the way that this is implemented and querying per feature vs against all of them order does not work. I am happy to do a PR to fix this, however I need some direction. I think the cleaner way would be to run the query against all the features so you get proper order and limiting/skipping but I don't know if there was a reason for one offing the queries. The other option is to build out a custom (or use some lib) to do ordering on the data outside of alasql.

efbenson commented 6 years ago

Covered in PR #85

rgwozdz commented 6 years ago

Moved ordering and esriFy to SQL in https://github.com/koopjs/winnow/pull/90; released in v1.16.1.