koorchik / Mojolicious-Plugin-RenderFile

"render_file" helper for Mojolicious to render static files
16 stars 13 forks source link

Windows PPM contains conflicting README.html #12

Open sierracc opened 9 years ago

sierracc commented 9 years ago

Hi,

the 0.09 Windows PPM package available from ActiveState contains a README.html conflicting with another README.html. As far as I can see, the README.pod is converted to README.html during the PPM generation process and placed in the Mojolicious main plugins directory, conflicting with other files there.

Mojolicious::Plugin::ParamExpand had the same issue, leading to a conflict when RenderFile is already installed. The issue has been fixed there (see: https://github.com/sshaw/Mojolicious-Plugin-ParamExpand/issues/3) but it should be done here as well as it may also happen with other plugins.

I guess all plugins should avoid writing to a file with a non-unique name in the plugins directory.

Below is a copy of the error within the ActiveState Perl Package Manager when installing ParamExpand while RenderFile is already installed.


Synchronizing Database done Mojolicious-Plugin-ParamExpand marked for install Installing package ... Downloading Mojolicious-Plugin-ParamExpand-0.02 ... done Unpacking Mojolicious-Plugin-ParamExpand-0.02 ... done Generating HTML for Mojolicious-Plugin-ParamExpand-0.02 ... done Updating files in site area ... failed Installing package failed

ERROR: File conflict for 'C:/Perl64/html/site/lib/Mojolicious/Plugin/README.html'. The package Mojolicious-Plugin-RenderFile has already installed a file that package Mojolicious-Plugin-ParamExpand wants to install.


Yours, André

sshaw commented 9 years ago

Apparently ppm only respects local ppm settings, ignoring INSTALL.SKIP. See this for more info.