search

koorchik / node-mole-rpc

Transport agnostic spec compliant JSON RPC client and server
MIT License
61 stars 13 forks source link

Passing in invalid JSON kills the process #23

Open jottinger opened 2 years ago

jottinger commented 2 years ago

If you submit invalid JSON, the parser blows up exits the process.

justin0mcateer commented 1 month ago

There doesn't appear to be any exception handling of JSON.stringify or JSON.parse calls on the client. The server at least catches exceptions on JSON.parse, but it should return a proper JSON-RPC error, instead it silently ignores the message.