koordinates / kart

Distributed version-control for geospatial and tabular data
https://kartproject.org
Other
515 stars 39 forks source link

Terminal freeze after installing tab completions for fish shell #948

Open andreatitolo opened 7 months ago

andreatitolo commented 7 months ago

Describe the bug I installed the fish completions using kart install tab-completions --shell fish. When I start typing a kart command, pressing TAB freezes the terminal (doesn't matter the terminal emulator), without any completion showing up, and I am forced to quit the application.

I don't know if it matters, but fish is not my login shell.

To Reproduce Steps to reproduce the behaviour:

  1. Install fish completions
  2. Type any kart command
  3. Press tab to bring up completions
  4. Terminal freezes

Expected behaviour For the completions to show up properly and not freezing the terminal

Version Info

rcoup commented 7 months ago

Hi!

Can you try doing export KART_USE_HELPER=0 and see if that makes any difference?

andreatitolo commented 7 months ago

Setting set -gx KART_USE_HELPER 0 in my fish.conf (should be the equivalent of the above command) works! Just out of curiosity, what does that setting do?

rcoup commented 7 months ago

Thanks — we use a background helper to speed up process startup for Kart on macOS + Linux. I guess it's interacting funkily with fish or tab completion somehow.

andreatitolo commented 7 months ago

Thanks for explaining, I'll close the issue as I don't have any freeze anymore, and I did not notice any slowdown or similar.

rcoup commented 7 months ago

I'll reopen it until someone gets a chance to try and reproduce it or figure out what the issue is.