koordinator-sh / koordinator

A QoS-based scheduling system brings optimal layout and status to workloads such as microservices, web services, big data jobs, AI jobs, etc.
https://koordinator.sh
Apache License 2.0
1.31k stars 327 forks source link

scheduler: fix pod update when pod creation is before quota creation #2177

Closed shaloulcy closed 1 month ago

shaloulcy commented 1 month ago

Ⅰ. Describe what this PR does

fix pod update when pod creation is before quota creation

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.87%. Comparing base (e1d910a) to head (d1b7dc0). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2177 +/- ## ========================================== - Coverage 67.90% 67.87% -0.04% ========================================== Files 443 443 Lines 41967 41971 +4 ========================================== - Hits 28496 28486 -10 - Misses 11016 11029 +13 - Partials 2455 2456 +1 ``` | [Flag](https://app.codecov.io/gh/koordinator-sh/koordinator/pull/2177/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=koordinator-sh) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/koordinator-sh/koordinator/pull/2177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=koordinator-sh) | `67.87% <100.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=koordinator-sh#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

saintube commented 1 month ago

/lgtm

koordinator-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/scheduler/OWNERS](https://github.com/koordinator-sh/koordinator/blob/main/pkg/scheduler/OWNERS)~~ [hormes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment