koordinator-sh / koordinator

A QoS-based scheduling system brings optimal layout and status to workloads such as microservices, web services, big data jobs, AI jobs, etc.
https://koordinator.sh
Apache License 2.0
1.31k stars 327 forks source link

scheduler: fix ElasticQuota state's Clone #2190

Closed saintube closed 3 weeks ago

saintube commented 4 weeks ago

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.70%. Comparing base (d9c40a5) to head (319a385). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2190 +/- ## ========================================== + Coverage 67.68% 67.70% +0.02% ========================================== Files 446 446 Lines 42696 42697 +1 ========================================== + Hits 28897 28909 +12 + Misses 11277 11267 -10 + Partials 2522 2521 -1 ``` | [Flag](https://app.codecov.io/gh/koordinator-sh/koordinator/pull/2190/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=koordinator-sh) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/koordinator-sh/koordinator/pull/2190/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=koordinator-sh) | `67.70% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=koordinator-sh#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shaloulcy commented 4 weeks ago

/lgtm

ZiMengSheng commented 3 weeks ago

/lgtm

ZiMengSheng commented 3 weeks ago

/approve

koordinator-bot[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/scheduler/OWNERS](https://github.com/koordinator-sh/koordinator/blob/main/pkg/scheduler/OWNERS)~~ [ZiMengSheng] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment