koordinator-sh / koordinator

A QoS-based scheduling system brings optimal layout and status to workloads such as microservices, web services, big data jobs, AI jobs, etc.
https://koordinator.sh
Apache License 2.0
1.36k stars 331 forks source link

scheduler: support pod preemption from numa awareless reservation #2204

Closed ZiMengSheng closed 2 months ago

ZiMengSheng commented 2 months ago

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base (36cb609) to head (0395fb9). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/scheduler/plugins/nodenumaresource/preempt.go 28.57% 5 Missing :warning:
...duler/plugins/nodenumaresource/resource_manager.go 20.00% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2204 +/- ## ========================================== - Coverage 67.70% 67.69% -0.02% ========================================== Files 446 446 Lines 42695 42715 +20 ========================================== + Hits 28908 28915 +7 - Misses 11266 11275 +9 - Partials 2521 2525 +4 ``` | [Flag](https://app.codecov.io/gh/koordinator-sh/koordinator/pull/2204/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=koordinator-sh) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/koordinator-sh/koordinator/pull/2204/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=koordinator-sh) | `67.69% <25.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=koordinator-sh#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

saintube commented 2 months ago

/lgtm

ZiMengSheng commented 2 months ago

/approve