koordinator-sh / koordinator

A QoS-based scheduling system brings optimal layout and status to workloads such as microservices, web services, big data jobs, AI jobs, etc.
https://koordinator.sh
Apache License 2.0
1.36k stars 331 forks source link

scheduler: support reservation name, taints and tolerations #2207

Closed saintube closed 1 month ago

saintube commented 2 months ago

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #2183, #2184.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 59.27602% with 90 lines in your changes missing coverage. Please review.

Project coverage is 67.15%. Comparing base (f959cdb) to head (e15490e). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/scheduler/frameworkext/reservation_info.go 0.00% 24 Missing :warning:
pkg/util/reservation/reservation.go 11.53% 23 Missing :warning:
pkg/scheduler/plugins/reservation/transformer.go 51.16% 11 Missing and 10 partials :warning:
pkg/scheduler/plugins/reservation/plugin.go 85.57% 11 Missing and 4 partials :warning:
.../frameworkext/eventhandlers/reservation_handler.go 70.83% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2207 +/- ## ========================================== - Coverage 67.21% 67.15% -0.06% ========================================== Files 451 451 Lines 43267 43399 +132 ========================================== + Hits 29082 29145 +63 - Misses 11642 11704 +62 - Partials 2543 2550 +7 ``` | [Flag](https://app.codecov.io/gh/koordinator-sh/koordinator/pull/2207/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=koordinator-sh) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/koordinator-sh/koordinator/pull/2207/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=koordinator-sh) | `67.15% <59.27%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=koordinator-sh#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zwzhang0107 commented 1 month ago

add some comments that PreferNoSchedule/NoExecute is not supported yet for reservation.toleration?