search

kooyeed / oauth

Automatically exported from code.google.com/p/oauth
0 stars 0 forks source link

Review changes to PHP library regarding parameter-parsing and handling #103

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes on this branch:

Two major changes:

1) I have change the way parameters are stored, to enabled duplicate parameters
2) I have moved quite a bit of code to OAuthUtil because they were 
utility-functions..

Futhermore I have:
- Moved SampleOAuthDataStore from OAuth.php to 
examples/SampleOAuthDataStore.php 
because it was just that, an example
- Restructured the tests a bit
- Added tons of tests. OAuthRequest and OAuthUtil now has 100% code-coverage in 
the tests..

When reviewing my code changes, please focus on:

1) Functionality
2) BC-breaks - I know there are some related to get_parameter / get_parameters, 
but are there 
any other?
3) Coding-style in OAuth.php

After the review, I'll merge this branch into:
/code/php

Original issue reported on code.google.com by morten.f...@gmail.com on 16 May 2009 at 1:56

GoogleCodeExporter commented 9 years ago 
Set review issue status to: Invalid

Original comment by morten.f...@gmail.com on 16 May 2009 at 2:43