Fix unexpected etcd image error if docker pulls images over proxy

kopeio / etcd-manager

operator for etcd: moved to https://github.com/kubernetes-sigs/etcdadm

Apache License 2.0

164 stars 45 forks source link

Closed kirrmann closed 5 years ago

kirrmann commented 5 years ago

I tried to use etcd-manager in kops which is setup to use a proxy to pull docker images.

spec:
  assets:
    containerProxy: nexus.internal:8500

But starting etcd-manager would always abort with error initializing etcd server: unexpected etcd image \“nexus.internal:8500/etcd:2.2.1\“

The two colons do incorrectly let a check fail to verify the specified name of the etcd docker image.

kirrmann commented 5 years ago

tests run fine locally. Seems like the travis builds just have time outs

justinsb commented 5 years ago

Thanks @kirrmann - and I believe we've fixed those timeouts on head (but travis does not rebase before testing).

I tweaked the logic so that it would pick up the version even in the "3 component" case, but thanks for reporting & fixing!

/approve /lgtm