search

kopeio / etcd-manager

operator for etcd: moved to https://github.com/kubernetes-sigs/etcdadm
Apache License 2.0
164 stars 45 forks source link

Ensure that FindMountedVolume returns ("", nil) when not found #276

Closed justinsb closed 4 years ago

justinsb commented 4 years ago

This helps the retry logic work correctly.

justinsb commented 4 years ago

Actually @zetaab would you mind looking at this ... I think the retry loop might return an error when it times out, which isn't really what we want. The problem is that it isn't always possible to cancel a disk attachment (e.g. on AWS) so our best bet is to just keep waiting. I don't know if OpenStack has a better option that actually works!

justinsb commented 4 years ago

Thanks!