search

kopeio / etcd-manager

operator for etcd: moved to https://github.com/kubernetes-sigs/etcdadm
Apache License 2.0
164 stars 45 forks source link

Upgrade aws-sdk-go #320

Closed rifelpet closed 4 years ago

rifelpet commented 4 years ago

This adds support for the new af-south-1 and eu-south-1 regions

Ref: https://github.com/kubernetes/kops/issues/9012

rifelpet commented 4 years ago

@justinsb think we could get this in with the cert fix?

rifelpet commented 4 years ago

ah looks like i just missed 3.0.20200428 :)

justinsb commented 4 years ago

Yeah, looks like unfortunate timing. We really need a (low-volume) slack room - I'll see if I can get one.

We could do a 20200429 release (technically I can even force it a day early).

rifelpet commented 4 years ago

consider holding for yet another new region https://aws.amazon.com/blogs/aws/now-open-aws-europe-milan-region/ waiting on a new aws-sdk-go release

justinsb commented 4 years ago

I've also realized that because kops itself won't support these new regions, we wouldn't necessarily backport it anyway (or at least, wouldn't backport it as far as the cert rotation fix).

So (inadvertently, perhaps) I think we've done the right thing by keeping 0428 minimal, we backport that as far as we can, then we do 0429 and don't backport it as far.

rifelpet commented 4 years ago

Updated to include both af-south-1 and eu-south-1

justinsb commented 4 years ago

Looks good - thanks @rifelpet

/approve /lgtm