search

kopeio / etcd-manager

operator for etcd: moved to https://github.com/kubernetes-sigs/etcdadm
Apache License 2.0
164 stars 45 forks source link

(Issue #331) Supporting etcd version 3.4.7 for k8s >= 1.19 #332

Closed mmerrill3 closed 4 years ago

mmerrill3 commented 4 years ago

Signed-off-by: mmerrill3 michael.merrill@vonage.com

Issue #331 Supporting etcd version 3.4.7 for k8s versions greater than or equal to 1.19

mmerrill3 commented 4 years ago

/assign @justinsb

mmerrill3 commented 4 years ago

@justinsb this is giving k8s users with version 1.19 or above the option to use etcd 3.4.7. This is the version supported out of the box by kubeadm.

justinsb commented 4 years ago

Thanks for the @mmerrill3, and sorry it took so long to get to it.

The challenge is that technically etcd can still be bumped because we haven't released k8s 1.19 yet, and in fact it's already been bumped to 3.4.9 https://github.com/kubernetes/kubernetes/blob/master/build/workspace.bzl

If we could figure out a nice way to not have to embed every etcd version into the image this wouldn't be a problem, but until we do these slots are "precious". We are intending to merge with etcdadm, which would likely have a better model here ... maybe it's time to tackle that!

I can ask around to know if another etcd upgrade is likely before the 1.19 release; I'm assuming not, but I've also heard that the k8s release candidates are not testing particularly well right now.

rifelpet commented 4 years ago

K8s 1.19 was just released with etcd 3.4.9 (see the end of this list). Can you update this PR to match?

hakman commented 4 years ago

K8s 1.19 was just released with etcd 3.4.9 (see the end of this list). Can you update this PR to match?

etcd was just updated to 3.4.13 in https://github.com/kubernetes/kubernetes/pull/94536.

hakman commented 4 years ago

I created https://github.com/kopeio/etcd-manager/pull/344 for v3.4.13.

mmerrill3 commented 4 years ago

closing since this is superceded by #344