search

kopeio / etcd-manager

operator for etcd: moved to https://github.com/kubernetes-sigs/etcdadm
Apache License 2.0
164 stars 47 forks source link

OpenStack virtio-scsi device path can contain full cinder uuid instead of shorten one #357

Open goberle opened 3 years ago

goberle commented 3 years ago

Same issue than : https://github.com/kubernetes/cloud-provider-openstack/issues/852

root@master-nova-1-1-dnum-k8s-dev-k8s-local:/mnt# ls /dev/disk/by-id/ scsi-0QEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b
scsi-SQEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b scsi-0QEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b-part1
scsi-SQEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b-part1 scsi-0QEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b-part14
scsi-SQEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b-part14 scsi-0QEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b-part15
scsi-SQEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b-part15 scsi-0QEMU_QEMU_HARDDISK_4f70c734-cc89-44cd-89fa-6858e31da7aa
scsi-SQEMU_QEMU_HARDDISK_4f70c734-cc89-44cd-89fa-6858e31da7aa scsi-0QEMU_QEMU_HARDDISK_b38e8c0d-1998-425c-ad5d-749f5cfb98ed
scsi-SQEMU_QEMU_HARDDISK_b38e8c0d-1998-425c-ad5d-749f5cfb98ed

and it doesn't match any of patterns which plugin looks for:

candidateDeviceNodes := []string{
    // KVM
    fmt.Sprintf("virtio-%s", volumeID[:20]),
    // KVM virtio-scsi
    fmt.Sprintf("scsi-0QEMU_QEMU_HARDDISK_%s", volumeID[:20]),
    // ESXi
    fmt.Sprintf("wwn-0x%s", strings.Replace(volumeID, "-", "", -1)),
}
goberle commented 3 years ago

Pull request : https://github.com/kopeio/etcd-manager/pull/358

hakman commented 3 years ago

CC @olemarkus @zetaab

zetaab commented 3 years ago

PR is merged, so this should be closed