search

kopeio / etcd-manager

operator for etcd: moved to https://github.com/kubernetes-sigs/etcdadm
Apache License 2.0
164 stars 47 forks source link

Added full cinder ID to candidateDeviceNodes #358

Closed goberle closed 3 years ago

justinsb commented 3 years ago

This seems safe, because this is a candidate list, and these values are more complete than the 20 characters we've used before. Going to merge - but let me know if there's a reason to revert @olemarkus or @zetaab !

/approve /lgtm

justinsb commented 3 years ago

Thanks again @goberle!

Have you signed the kubernetes CLA? We're trying to merge this project into the kubernetes-sigs etcdadm project ( https://github.com/kubernetes-sigs/etcdadm/pull/180#issuecomment-730408940 ), and you can see we're hitting some CLA issues. I don't know if it's your account or someone else's though... Have you signed the CLA (or are you able to sign the CLA?)

goberle commented 3 years ago

Hi @justinsb

Thanks for the merge. I just signed the kubernetes CLA a minute ago, it should be ok now. Let me know if there is any more issues for merging upstream.