search

kopeio / etcd-manager

operator for etcd: moved to https://github.com/kubernetes-sigs/etcdadm
Apache License 2.0
164 stars 47 forks source link

Update Go to 1.15.7 #359

Closed hakman closed 3 years ago

hakman commented 3 years ago

... to match kOps.

justinsb commented 3 years ago

Looks good. Any reason not to update rules-go to a newer version that recognizes the newer go version?

hakman commented 3 years ago

Looks good. Any reason not to update rules-go to a newer version that recognizes the newer go version?

I guess not in etcd-manager. In kOps it was a problem with output path changes for binaries for which me and @rifelpet couldn't find a simple solution.

justinsb commented 3 years ago

Ah - that makes sense. Let's stick with what you've got here for now, for consistency then.

/approve /lgtm

justinsb commented 3 years ago

Fix for the deprecation should be in #362

justinsb commented 3 years ago

I merged #362 - do you want to rebase and then I can cut a release? Or should we leave this one till the next etcd-manager release?

hakman commented 3 years ago

Let's leave for next release please. Until then maybe we can do it in a nicer way, similar to https://github.com/kubernetes/kops/pull/10240.

hakman commented 3 years ago

@justinsb this should make things identical to kOps now.

hakman commented 3 years ago

@justinsb I think tis is now ready to go.

justinsb commented 3 years ago

@hakman do you think we should try to do this before kops 1.19.0?

hakman commented 3 years ago

@justinsb I think it may be safer to merge this after the new release for 1.19 and create a new release that we will use only on master for now. We will include it later in 1.19.1 if no issues are discovered.

rifelpet commented 3 years ago

Kops 1.19 is built with 1.15.4 for reference

hakman commented 3 years ago

Addressing that with https://github.com/kubernetes/kops/pull/10603.

justinsb commented 3 years ago

We discussed in "bonus" office hours that because we consider #391 to be important, we're going to merge this (with 1.15.7 IIRC) and test with #391, and so this will now make 1.19.0 :-)

hakman commented 3 years ago

And... success. Looks like both PRs passed the tests.