Update Kops dependency for Azure Blob Storage support

kopeio / etcd-manager

operator for etcd: moved to https://github.com/kubernetes-sigs/etcdadm

Apache License 2.0

164 stars 47 forks source link

Update Kops dependency for Azure Blob Storage support #372

Closed rifelpet closed 3 years ago

rifelpet commented 3 years ago

This updates the kops dependency to the current master HEAD. note that the go.mod replace directive is changing from v1.19.0-beta.1 to v1.19.0-alpha.5.0.20201129060248-dc1c2210cf77 because v1.19.0-alpha.5 is the most recent tag cut from the master branch before we created the release-1.19 branch.

This also updates klog to v2.

justinsb commented 3 years ago

So I think I messed this up with the tools/deb-tools subdirectory.

The next 3 PRs should fix it properly, but if you want this one to pass tests I think this should do it...

pushd tools/deb-tools
go mod vendor
bazel run //:gazelle
popd

rifelpet commented 3 years ago

Thanks @justinsb, updated. I think one issue is gazelle is using the wrong prefix for the deb-tools module: https://github.com/kopeio/etcd-manager/blob/e694496d2e2de6d73df764b46373bcdd4d7ce183/tools/deb-tools/BUILD.bazel#L8

justinsb commented 3 years ago

Thanks @rifelpet and you're right - that should be deb-tools not deb-extract. It might work anyway, but I agree we should fix it :-)

justinsb commented 3 years ago

Removing travis in #377, so not going to wait for it. The same tests are passing in github actions.

/approve /lgtm