Dangerous option "Disable Parent Policy Evaluation" destroyed all my snapshots!

kopia / kopia

Cross-platform backup tool for Windows, macOS & Linux with fast, incremental backups, client-side end-to-end encryption, compression and data deduplication. CLI and GUI included.

https://kopia.io

Apache License 2.0

7.96k stars 397 forks source link

Dangerous option "Disable Parent Policy Evaluation" destroyed all my snapshots! #1732

Open stephen322 opened 2 years ago

stephen322 commented 2 years ago

Using HTTP UI, I have a policy for my root folder and select "Scan only one filesystem" with various custom options. I then make separate policies for other mounts. After a while, I found the other mounts had inherited root. Since I do not want the custom options from the root folder coming over to the mounts, I select "Disable Parent Policy Evaluation".

It appears this also disabled the global policy, not just "parent" folders. If I'm right on what is happening: with no snapshot retention set in the policy, all snapshots get deleted on next run.

If there is no retention policy, default behavior should be to keep all snapshots until deleted manually? "Disable Parent Policy Evaluation" should also have a default sub option to keep global policy in effect?

jkowalski commented 2 years ago

Oh, sorry to hear that and yes-you're correct about the behavior of retention policy. This global noParent flag was introduced very early on when the policies had only basic features, I guess we did not consider all the implications of that flag.

I'm thinking we should:

[ ] P0: make it so "retention policy with all zeroes" == "don't delete anything" and print a warning to users when they snapshot with such retention
[ ] P1: make "disable parent policy evaluation" flag be specific to each policy section (so have individual flags for retention, one for ignore rules, and so on)
[ ] P1: deprecate global "disable parent policy evaluation" and print big fat warnings if somebody is still using it

SayakMukhopadhyay commented 10 months ago

Hey @julio-lopez , I am interested in disabling retention and I see that a PR #1733 was merged. Seems like it was released but still can you please confirm that it was released?

thel3l commented 6 days ago

Hey guys!

Thank you for your work, really appreciate it, Kopia seems like an incredible tool.

Just bumping this to confirm since it is an open issue on the forums as well—does setting 0 on all the retention policies disable snapshots from ever being deleted or does it not retain any snapshots?