search

koppen / redmine_github_hook

Allow your Redmine installation to be notified when changes have been pushed to a Github repository.
http://mentalized.net/journal/2009/08/03/redmine_plugin_github_hook/
MIT License
478 stars 114 forks source link

Hello, #21

Closed therealmarv closed 11 years ago

therealmarv commented 12 years ago

(my first pull request contained wrong code). Maybe this is useful for you.

Marvin

koppen commented 12 years ago

Hey, thanks for your contribution. I must admit, I originally wanted the plugin to be able to work entirely without a configuration screen, because, you know, configuration is bad.

That said, going forward having the configuration screen is probably a good choice and allows us to help with debugging dependencies and whatnot, so let's see where it takes us.

That said, this change introduced some test breaking (and doesn't apply cleanly due to recent changes). Could you take a look at those issues, I'll be happy to merge this in.

therealmarv commented 12 years ago

Hi koppen. I will be very busy this week but I will try to test everything and merge the latest changes this weekend. So please give me some time :-)

koppen commented 12 years ago

No worries, I am not exactly mr Speed myself ;)