search

koppen / redmine_github_hook

Allow your Redmine installation to be notified when changes have been pushed to a Github repository.
http://mentalized.net/journal/2009/08/03/redmine_plugin_github_hook/
MIT License
478 stars 114 forks source link

Prune repo for deleted branches cleanup #42

Closed wronglink closed 9 years ago

wronglink commented 11 years ago

Right now if I make a new branch on remote server (github) it would appear on my redmine repo mirror. If then I delete that branch it would still remain there. Git has a remote prune command to make such cleanup.

BTW it would be usefull to have a couple of words in README that redmine local repos should be cloned with --mirror argument (not --bare).

koppen commented 11 years ago

Thank you for your contribution.

Has remote prune been around since Git 1.5 or do we need to bump the Git version assumption with these changes?

BTW it would be usefull to have a couple of words in README that redmine local repos should be cloned with --mirror argument (not --bare).

Currently, we've outsourced that part of the README to http://www.redmine.org/projects/redmine/wiki/HowTo_keep_in_sync_your_git_repository_for_redmine which does mention --mirror. I wouldn't mind an update for the pull request with similar instructions, though.

wronglink commented 11 years ago

Has remote prune been around since Git 1.5 or do we need to bump the Git version assumption with these changes? I haven't found any notes about remote prune since 1.6, so, I'm not sure about it. Unfortunately git (as a software) changelog or history is not the best word combination to google (most results describe git log command variations).

Currently, we've outsourced that part of the README to... Well, I see. Sorry didn't note this. I think it's OK to leave it as is.

wronglink commented 11 years ago

Any way this could be merged to the master?

koppen commented 11 years ago

Yes, it sounds like a great addition.

I haven't verified the tests yet, but seeing how there are none in the pull request, I suspect they'll fail. Have you taken/can you take a look at this?

wronglink commented 10 years ago

I guess I can add some tests for this case and update PR to fix conflicts. Sorry for that timeout.

koppen commented 9 years ago

This has been merged in 122ad0e26b7682c96631d0f1d5e06640cc2131a4, sorry for the ridiculous delay.