search

koppen / redmine_github_hook

Allow your Redmine installation to be notified when changes have been pushed to a Github repository.
http://mentalized.net/journal/2009/08/03/redmine_plugin_github_hook/
MIT License
478 stars 114 forks source link

TypeError (can't convert nil into String) #5

Closed t0ster closed 14 years ago

t0ster commented 14 years ago

I'm getting:

Processing GithubHookController#index (for 82.193.109.185 at 2010-09-16 12:09:31) [GET]
  Parameters: {"action"=>"index", "controller"=>"github_hook"}
  SQL (0.6ms)   SELECT max("settings".updated_on) AS max_updated_on FROM "settings" 
  AnonymousUser Load (1.5ms)   SELECT * FROM "users" WHERE ( ("users"."type" = 'AnonymousUser' ) ) LIMIT 1

TypeError (can't convert nil into String):
  json (1.4.6) lib/json/common.rb:146:in `initialize'
  json (1.4.6) lib/json/common.rb:146:in `new'
  json (1.4.6) lib/json/common.rb:146:in `parse'
  vendor/plugins/redmine_github_hook/app/controllers/github_hook_controller.rb:43:in `get_identifier'
  vendor/plugins/redmine_github_hook/app/controllers/github_hook_controller.rb:51:in `find_project'
  vendor/plugins/redmine_github_hook/app/controllers/github_hook_controller.rb:59:in `find_repository'
  vendor/plugins/redmine_github_hook/app/controllers/github_hook_controller.rb:9:in `index'
t0ster commented 14 years ago

Sorry, it seams to be normal behavior when trying to access http://redmine/github_hook from browser

koppen commented 14 years ago

Correct. The action isn't meant to be requested manually, but solely by Github service hooks.

jeff-dagenais commented 10 years ago

Hi, I'm setting the plugin up on a redmine 1.4 install (github_hook at v1.1.0). I have a local "mirror" git clone for which my apache user (www-data) has read-write access. I can

su www-data
cd my_local_clone
git fetch

without problem. My original repo is a local gitlab repo for which I have setup the webhook correctly. Here's my redmine's production.log output for a dummy commit:

Processing GithubHookController#index (for 192.168.128.11 at 2014-04-28 13:37:51) [POST]
  Parameters: {"repository"=>{"name"=>"g3", "url"=>"git@gitlab.xx:soft/g3.git", "homepage"=>"http://gitlab.xx/soft/g3", "description"=>""}, "project_id"=>"g3", "action"=>"index", "after"=>"4d56
7106fabc5c8c9cfb52c24c80629537b4428d", 

[...]
 "timestamp"=>"2014-04-28T13:37:39-04:00", "url"=>"http://gitlab.xx/soft/g3/commit/4d567106fabc5c8c9cfb52c24c80629537b4428d", "id"=>"4d567106fabc5c8c9cfb52c24c80629537b4428d", "message"=>"dummy commit."}], "ref"=>"refs/heads/jfdtest", "before"=>"03337edcaf08f11193e634ab95fe8e412efffdf1", "total_commits_count"=>103}

TypeError (can't convert nil into String):
  json (1.8.1) lib/json/common.rb:155:in `initialize'
  json (1.8.1) lib/json/common.rb:155:in `new'
  json (1.8.1) lib/json/common.rb:155:in `parse'
  vendor/plugins/redmine_github_hook/app/controllers/github_hook_controller.rb:45:in `get_identifier'
  vendor/plugins/redmine_github_hook/app/controllers/github_hook_controller.rb:53:in `find_project'
  vendor/plugins/redmine_github_hook/app/controllers/github_hook_controller.rb:61:in `find_repository'
  vendor/plugins/redmine_github_hook/app/controllers/github_hook_controller.rb:9:in `index'
  passenger (2.2.14) lib/phusion_passenger/rack/request_handler.rb:92:in `process_request'
  passenger (2.2.14) lib/phusion_passenger/abstract_request_handler.rb:207:in `main_loop'
  passenger (2.2.14) lib/phusion_passenger/railz/application_spawner.rb:441:in `start_request_handler'
  passenger (2.2.14) lib/phusion_passenger/railz/application_spawner.rb:381:in `handle_spawn_application'
  passenger (2.2.14) lib/phusion_passenger/utils.rb:252:in `safe_fork'
  passenger (2.2.14) lib/phusion_passenger/railz/application_spawner.rb:377:in `handle_spawn_application'
  passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:352:in `__send__'
  passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:352:in `main_loop'
  passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:196:in `start_synchronously'
  passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:163:in `start'
  passenger (2.2.14) lib/phusion_passenger/railz/application_spawner.rb:222:in `start'
  passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:262:in `spawn_rails_application'
  passenger (2.2.14) lib/phusion_passenger/abstract_server_collection.rb:126:in `lookup_or_add'
  passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:256:in `spawn_rails_application'
  passenger (2.2.14) lib/phusion_passenger/abstract_server_collection.rb:80:in `synchronize'
  passenger (2.2.14) lib/phusion_passenger/abstract_server_collection.rb:79:in `synchronize'
  passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:255:in `spawn_rails_application'
  passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:154:in `spawn_application'
  passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:287:in `handle_spawn_application'
  passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:352:in `__send__'
  passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:352:in `main_loop'
  passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:196:in `start_synchronously'

Rendering /var/www/railsapp/public/500.html (500 Internal Server Error)

Any suggestion?

koppen commented 10 years ago

@jeff-dagenais, please open a new issue if you're still having issues.

jeff-dagenais commented 10 years ago

I guess my issue was related to #33. I checked out the head of redmine_1.x instead of the tag and the problem is gone.

Perhaps you should git tag v1.1.1 refs/heads/redmine_1.x

Thanks!