search

koppen / redmine_github_hook

Allow your Redmine installation to be notified when changes have been pushed to a Github repository.
http://mentalized.net/journal/2009/08/03/redmine_plugin_github_hook/
MIT License
478 stars 114 forks source link

Gemify commit breaks existing "git clone"-installations #52

Closed tofi86 closed 10 years ago

tofi86 commented 10 years ago

Hi, I have the plugin installed as a git clone in my plugins directory. This always worked very well, until you introduced the gemify commit.

I just wanted to upgrade to the latest version and after my git pull now get that for plugin-upgrades:

$ # rake redmine:plugins:migrate RAILS_ENV=production
There are no gemspecs at /var/www/projekte/redmine-2.4.

After switching back to commit before "gemify", verything works as expected.

Please have a look and restore git cloning functionality!

Thanks, Tobias

koppen commented 10 years ago

Cheers, thanks for reporting this. I didn't actually check that the cloned install still worked. It should work now, can you verify this?

That said, I suspect the git-based install might go away eventually in favor of doing it entirely via gems, which does give some benefits. You should be able to achieve the best of both worlds by adding

gem "redmine_github_hook", :github => "koppen/redmine_github_hook"

to your Gemfile.local, though.

tofi86 commented 10 years ago

thanks for fixing. however it seems as if I have to update my bundler version...

Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    bundler (~> 1.5) ruby

  Current Bundler version:
    bundler (1.3.5)

This Gemfile requires a different version of Bundler.
Perhaps you need to update Bundler by running `gem install bundler`?

as you require bundler 1.5 and I have 1.3.5 installed...

I'll have a look at the weekend how to update bundler without breaking anything else... :-/

tofi86 commented 10 years ago

Alright, also works with updated bundler gem (v1.5.3).